git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: GIT_COMMITTER_* and reflog

From
Jeff King <peff@peff.net>
Date
Oct 29, 2019, 14:34 UTC
Message-ID
<20191029143420.GB3683@sigill.intra.peff.net>
In-Reply-To
<xmqqr22ybcs7.fsf@gitster-ct.c.googlers.com>
On Sun, Oct 27, 2019 at 09:20:24PM +0900, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > If somebody wants to pursue a patch, I suspect the solution is probably
> > something like this (totally untested):
> 
> Looks sensible.  It is very much unsatisfying that datestamp(),
> which is used by fmt_ident() when no date string is given, seems to
> totally bypass date.c::get_time(), which means the framework to give
> fake timestamp via GIT_TEST_DATE_NOW cannot be used to write
> reproducible tests.
> 
> Given that datestamp() is only used by the push certificate and
> fast-import codepaths and nowhere else, I suspect that "fixing" it
> retroactively to honor GIT_TEST_DATE_NOW would not have any negative
> fallout, but that's not something I should be contemplating on
> during the -rc period ;-)

Yeah, I agree datestamp() should respect $GIT_TEST_DATE_NOW. This whole topic is not something for the -rc period, I would think.

-Peff
Previous: Phillip Wood
Message 9 of 9 in “GIT_COMMITTER_* and reflog”
  1. Luke DashjrOct 25, 2019
  2. Jonathan NiederOct 26, 2019
  3. Luke DashjrOct 26, 2019
  4. Philip OakleyNov 7, 2019
  5. Junio C HamanoOct 26, 2019
  6. Jeff KingOct 26, 2019
  7. Junio C HamanoOct 27, 2019
  8. Phillip WoodOct 29, 2019
  9. Jeff KingOct 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.