git/list[1] front-page[2] threads[3] people[4] search[5] about
 

GIT_COMMITTER_* and reflog

From
LDLuke Dashjr <luke@dashjr.org>
Date
Oct 25, 2019, 21:49 UTC
Message-ID
<201910252149.23787.luke@dashjr.org>

It appears the reflog currently allows its log data (name and date) to be overridden by the GIT_COMMITTER_* environment variables. At least for my workflow, this kinda breaks the reflog (as I regularly set GIT_COMMITTER_DATE to produce deterministic commit objects).

Is there a need to support this override for the reflog? Is there any reason it can't be changed to use GIT_REFLOG_* instead?

Note that the reflog does NOT pull the name/date from the commit object itself, but rather calls git_committer_info() to get a new name/date for reflog purposes. So it does not appear to be intentionally designed to use the commit's date.

Thanks for your thoughts,
Luke

P.S. If the reflog date can be made useful like this, maybe I will finish a minor patch to add reflog-date to the pretty formatting format so it can be viewed nicely... ;)

Next: Jonathan Nieder
Message 1 of 9 in “GIT_COMMITTER_* and reflog”
  1. Luke DashjrOct 25, 2019
  2. Jonathan NiederOct 26, 2019
  3. Luke DashjrOct 26, 2019
  4. Philip OakleyNov 7, 2019
  5. Junio C HamanoOct 26, 2019
  6. Jeff KingOct 26, 2019
  7. Junio C HamanoOct 27, 2019
  8. Phillip WoodOct 29, 2019
  9. Jeff KingOct 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.