Re: GIT_COMMITTER_* and reflog
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Oct 29, 2019, 14:05 UTC
- Message-ID
- <08310159-41f9-43e2-5d54-a48fd403ad07@gmail.com>
- In-Reply-To
- <xmqqr22ybcs7.fsf@gitster-ct.c.googlers.com>
Hi Junio/Peff
On 27/10/2019 12:20, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes: > >> If somebody wants to pursue a patch, I suspect the solution is probably >> something like this (totally untested): > > Looks sensible. It is very much unsatisfying that datestamp(), > which is used by fmt_ident() when no date string is given, seems to > totally bypass date.c::get_time(), which means the framework to give > fake timestamp via GIT_TEST_DATE_NOW cannot be used to write > reproducible tests. > > Given that datestamp() is only used by the push certificate and > fast-import codepaths and nowhere else, I suspect that "fixing" it > retroactively to honor GIT_TEST_DATE_NOW would not have any negative > fallout, but that's not something I should be contemplating on > during the -rc period ;-)
It would allow for more robust am/rebase --ignore-date tests as we would know what date to expect rather than just checking the timezone.
Best Wishes
Phillip
Show 22 quoted lines
>
> Thanks.
>
>>
>> diff --git a/refs/files-backend.c b/refs/files-backend.c
>> index d60767ab73..2ebf2feeb8 100644
>> --- a/refs/files-backend.c
>> +++ b/refs/files-backend.c
>> @@ -1658,7 +1658,10 @@ static int files_log_ref_write(struct files_ref_store *refs,
>> if (logfd < 0)
>> return 0;
>> result = log_ref_write_fd(logfd, old_oid, new_oid,
>> - git_committer_info(0), msg);
>> + fmt_ident(getenv("GIT_COMMITTER_NAME"),
>> + getenv("GIT_COMMITTER_EMAIL"),
>> + WANT_COMMITTER_IDENT, NULL, 0),
>> + msg);
>> if (result) {
>> struct strbuf sb = STRBUF_INIT;
>> int save_errno = errno;
>>
>> -Peff