Re: [PATCH v2 0/9] midx: clean up t5319 under 'SANITIZE=leak'

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2021, 23:49 UTC
Message-ID: <xmqqv91it4de.fsf@gitster.g>
In-Reply-To: <cover.1635282024.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

> Here is a small-ish update to my series which makes t5319 leak-free (i.e., it
> passes even when Git is compiled with SANITIZE=leak). It is based on
> ab/only-single-progress-at-once (so I dropped the cherry-picked patch towards
> the end from Ævar).

The range-diff was almost unreadable, so I looked at the difference relative to the previous tip (i.e. "git diff @{1}"). I spotted two classes of changes, one is where and how "struct child_process" gets cleared, the other is how midx-related filenames are released. I think the latter changes are improvements, and among the former, the "write_oid() was never called, so cmd was left unused" change does look an improvement, but I do not know about the others.

Thanks.