[PATCH v2 3/9] t/helper/test-read-midx.c: free MIDX within read_midx_file()
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 26, 2021, 21:01 UTC
- Message-ID
- <84859d5b534606ab243b82afa119514f71ca1c03.1635282024.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1635282024.git.me@ttaylorr.com>
When calling `read_midx_file()` to show information about a MIDX or list the objects contained within it we fail to call `close_midx()`, leaking the memory allocated to store that MIDX.
Fix this by calling `close_midx()` before exiting the function. We can drop the "early" return when `show_objects` is non-zero, since the next instruction is also a return.
(We could just as easily put a `cleanup` label here as with previous patches. But the only other time we terminate the function early is when we fail to load a MIDX in the first place. `close_midx()` does handle a NULL argument, but the extra complexity is likely not warranted).
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- t/helper/test-read-midx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/helper/test-read-midx.c b/t/helper/test-read-midx.c index 9d6fa7a377..27072ba94d 100644 --- a/t/helper/test-read-midx.c +++ b/t/helper/test-read-midx.c @@ -55,9 +55,10 @@ static int read_midx_file(const char *object_dir, int show_objects) printf("%s %"PRIu64"\t%s\n", oid_to_hex(&oid), e.offset, e.p->pack_name); } - return 0; } + close_midx(m); + return 0; }
-- 2.33.0.96.g73915697e6