[PATCH v2 8/9] pack-bitmap.c: don't leak type-level bitmaps
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 26, 2021, 21:01 UTC
- Message-ID
- <77a445463298cac69f00a0b9c5b5951bae80b2dd.1635282024.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1635282024.git.me@ttaylorr.com>
test_bitmap_walk() is used to implement `git rev-list --test-bitmap`, which compares the result of the on-disk bitmaps with ones generated on-the-fly during a revision walk.
In fa95666a40 (pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps, 2021-08-24), we hardened those tests to also check the four special type-level bitmaps, but never freed those bitmaps. We should have, since each required an allocation when we EWAH-decompressed them.
Free those, plugging that leak, and also free the base (the scratch-pad bitmap), too.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- pack-bitmap.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/pack-bitmap.c b/pack-bitmap.c index 3f603425c9..3d81425c29 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -1726,6 +1726,12 @@ void test_bitmap_walk(struct rev_info *revs) else die("mismatch in bitmap results"); + bitmap_free(result); + bitmap_free(tdata.base); + bitmap_free(tdata.commits); + bitmap_free(tdata.trees); + bitmap_free(tdata.blobs); + bitmap_free(tdata.tags); free_bitmap_index(bitmap_git); }
-- 2.33.0.96.g73915697e6