[PATCH v2 6/9] builtin/multi-pack-index.c: don't leak concatenated options
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 26, 2021, 21:01 UTC
- Message-ID
- <0d252cd3239b9dca43fda37f7471b924440f6336.1635282024.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1635282024.git.me@ttaylorr.com>
The `multi-pack-index` builtin dynamically allocates an array of command-line option for each of its separate modes by calling add_common_options() to concatante the common options with sub-command specific ones.
Because this operation allocates a new array, we have to be careful to remember to free it. We already do this in the repack and write sub-commands, but verify and expire don't. Rectify this by calling FREE_AND_NULL as the other modes do.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- builtin/multi-pack-index.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/builtin/multi-pack-index.c b/builtin/multi-pack-index.c index 075d15d706..4480ba3982 100644 --- a/builtin/multi-pack-index.c +++ b/builtin/multi-pack-index.c @@ -167,6 +167,8 @@ static int cmd_multi_pack_index_verify(int argc, const char **argv) usage_with_options(builtin_multi_pack_index_verify_usage, options); + FREE_AND_NULL(options); + return verify_midx_file(the_repository, opts.object_dir, opts.flags); } @@ -191,6 +193,8 @@ static int cmd_multi_pack_index_expire(int argc, const char **argv) usage_with_options(builtin_multi_pack_index_expire_usage, options); + FREE_AND_NULL(options); + return expire_midx_packs(the_repository, opts.object_dir, opts.flags); }
-- 2.33.0.96.g73915697e6