Re: [PATCH v4] cvsserver: remove unused escapeRefName function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 27, 2025, 15:24 UTC
- Message-ID
- <xmqqv7pmqdo4.fsf@gitster.g>
- In-Reply-To
- <pull.1925.v4.git.1748267305871.gitgitgadget@gmail.com>
"Ondřej Pohořelský via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> Function 'escapeRefName' introduced in 51a7e6dbc9 has never been used. > > Despite being dead code, changes in Perl 5.41.4 exposed precedence > warning withing its logic, which then caused test failures in t9402 by > logging the warnings to stderr while parsing the code. The affected > tests are t9402.30, t9402.31, t9402.32 and t9402.34. > > Remove this unused function to simplify the codebase and stop the > warnings and test failures. Its corresponding unescapeRefName function, > which remains in use, has had its comments updated.
Very clearly explained and looking good. Thanks.
Will queue with "withing" -> "within".