Re: [PATCH v2] cvsserver: avoid precedence problem between ! and %s
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 22, 2025, 18:51 UTC
- Message-ID
- <xmqqtt5c5viq.fsf@gitster.g>
- In-Reply-To
- <aC9lM12GyntAp2tR@teonanacatl.net>
Todd Zullinger <tmz@pobox.com> writes:
Show 24 quoted lines
> Just for curiosity, the only commit found with escapeRefName > is when it was added: > > $ git log -G '\bescapeRefName\b' -- git-cvsserver.perl > commit 51a7e6dbc9 > Author: Matthew Ogilvie <mmogilvi_git@miniinfo.net> > Date: Sat Oct 13 23:42:26 2012 -0600 > > cvsserver: define a tag name character escape mechanism > > CVS tags are officially only allowed to use [-_0-9A-Za-f]. Git > refs commonly uses other characters, especially [./]. Such characters > need to be escaped from CVS in order to be referenced. > > This just defines functions to escape/unescape names. The functions > are not used yet. > > Signed-off-by: Matthew Ogilvie <mmogilvi_git@miniinfo.net> > Signed-off-by: Junio C Hamano <gitster@pobox.com> > > A subsequent commit, 658b57ad52 (cvsserver: add misc commit > lookup, file meta data, and file listing functions, > 2012-10-13), made use of unescapeRefName; escapeRefName > seems to have _never_ been used.
OK, so we can safely remove it, it seems ;-) I wonder what, if any, the unescaping side is unescaping, if we are not doing the escaping.
Thanks for digging.