Re: [PATCH] cvsserver: avoid precedence problem between ! and %s
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 21, 2025, 14:58 UTC
- Message-ID
- <xmqqplg2c8ow.fsf@gitster.g>
- In-Reply-To
- <pull.1925.git.1747813502225.gitgitgadget@gmail.com>
"Ondřej Pohořelský via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 10 quoted lines
> diff --git a/git-cvsserver.perl b/git-cvsserver.perl > index a4e1bad33ca..076c10cb2c2 100755 > --- a/git-cvsserver.perl > +++ b/git-cvsserver.perl > @@ -5009,7 +5009,7 @@ sub escapeRefName > # = "_-xx-" Where "xx" is the hexadecimal representation of the > # desired ASCII character byte. (for anything else) > > - if(! $refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/) > + if(! ($refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/))
Interesting. Shouldn't it be using !~ instead if it wants to assert that the refname does not match the pattern?
Show 5 quoted lines
> {
> $refName=~s/_-/_-u--/g;
> $refName=~s/\./_-p-/g;
>
> base-commit: cb96e1697ad6e54d11fc920c95f82977f8e438f8