Re: [PATCH] cvsserver: avoid precedence problem between ! and %s

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: May 21, 2025, 07:53 UTC
Message-ID: <b2abe6c5-042d-4842-9928-39b7fb7b2c0a@app.fastmail.com>
In-Reply-To: <pull.1925.git.1747813502225.gitgitgadget@gmail.com>

Hi

On Wed, May 21, 2025, at 09:45, Ondřej Pohořelský via GitGitGadget wrote:

Show 9 quoted lines

> From: =?UTF-8?q?Ond=C5=99ej=20Poho=C5=99elsk=C3=BD?= <opohorel@redhat.com>
>
> With perl-5.41.4 and newer, git-cvsserver fails to build because of
> possible precedence problem[0]
>
> Added parentheses avoid this issue.
>
> Full credit for finding the issue and coming up with the fix goes to
> Jitka Plesnikova (jplesnik@redhat.com)

You can mention the person in the trailer section above your signoff.  For example:

    Helped-by: Jitka Plesnikova <jplesnik@redhat.com>
    Signed-off-by: Ondřej Pohořelský <opohorel@redhat.com>

Or choose one of the other common ones (from `Documentation/SubmittingPatches`):

    If you like, you can put extra trailers at the end:

    . `Reported-by:` is used to credit someone who found the bug that
      the patch attempts to fix.
    . `Acked-by:` says that the person who is more familiar with the area
      the patch attempts to modify liked the patch.
    . `Reviewed-by:`, unlike the other trailers, can only be offered by the
      reviewers themselves when they are completely satisfied with the
      patch after a detailed analysis.
    . `Tested-by:` is used to indicate that the person applied the patch
      and found it to have the desired effect.
    . `Co-authored-by:` is used to indicate that people exchanged drafts
       of a patch before submitting it.
    . `Helped-by:` is used to credit someone who suggested ideas for
      changes without providing the precise changes in patch form.
    . `Mentored-by:` is used to credit someone with helping develop a
      patch as part of a mentorship program (e.g., GSoC or Outreachy).
    . `Suggested-by:` is used to credit someone with suggesting the idea
      for a patch.

-- 
Kristoffer Haugsbakk