Re: [PATCH v2 1/3] environment: simplify repository config getters
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 6, 2026, 16:50 UTC
- Message-ID
- <xmqqv79nkxc3.fsf@gitster.g>
- In-Reply-To
- <20260806092557.3951208-2-cat@malon.dev>
Tian Yuchen <cat@malon.dev> writes:
Show 5 quoted lines
> Drop unnecessary parentheses and NULL checks in repository config > getters. > > These getters are only used with non-NULL repositories, so the > extra checks do not match their current callers.
You would need to explain why it is sensible to enforce on future callers the same rule that current callers honor, or why it is unlikely that we will gain any more callers in the future (which would justify catering only to current callers).
Show 45 quoted lines
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
> Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
> Signed-off-by: Tian Yuchen <cat@malon.dev>
> ---
> environment.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/environment.c b/environment.c
> index 76ee65e62b..f5628b6758 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -119,23 +119,23 @@ int is_bare_repository(struct repository *repo)
>
> int repo_protect_ntfs(struct repository *repo)
> {
> - return (repo && repo->initialized) ?
> - repo_config_values(repo)->protect_ntfs :
> - PROTECT_NTFS_DEFAULT;
> + return repo->initialized
> + ? repo_config_values(repo)->protect_ntfs
> + : PROTECT_NTFS_DEFAULT;
> }
>
> int repo_protect_hfs(struct repository *repo)
> {
> - return (repo && repo->initialized) ?
> - repo_config_values(repo)->protect_hfs :
> - PROTECT_HFS_DEFAULT;
> + return repo->initialized
> + ? repo_config_values(repo)->protect_hfs
> + : PROTECT_HFS_DEFAULT;
> }
>
> int repo_ignore_case(struct repository *repo)
> {
> - return (repo && repo->initialized) ?
> - repo_config_values(repo)->ignore_case :
> - 0;
> + return repo->initialized
> + ? repo_config_values(repo)->ignore_case
> + : 0;
> }
>
> int repo_trust_executable_bit(struct repository *repo)