git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/3] environment: remove inaccurate repo_config_values comments

From
Tian Yuchen <cat@malon.dev>
Date
Aug 7, 2026, 08:59 UTC
Message-ID
<20260807085932.3958759-4-cat@malon.dev>
In-Reply-To
<20260807085932.3958759-1-cat@malon.dev>

The section comments in struct repo_config_values do not accurately describe all members grouped under them. Remove them rather than implying a relationship that does not exist.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
Signed-off-by: Tian Yuchen <cat@malon.dev>
---
 environment.h | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/environment.h b/environment.h
index 6f864c1635..67fd387d35 100644
--- a/environment.h
+++ b/environment.h
@@ -115,7 +115,6 @@ enum object_creation_mode {
 };
 
 struct repo_config_values {
-	/* section "core" config values */
 	char *attributes_file;
 	char *excludes_file;
 	char *editor_program;
@@ -139,11 +138,7 @@ struct repo_config_values {
 	int ignore_case;
 	int trust_executable_bit;
 	int has_symlinks;
-
-	/* section "sparse" config values */
 	int sparse_expect_files_outside_of_patterns;
-
-	/* section "branch" config values */
 	enum branch_track branch_track;
 };
 
-- 
2.43.0
Previous: Tian YuchenNext: Patrick Steinhardt
Message 23 of 27 in “environment: clean up repository config handling”
  1. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 5, 2026
  2. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 5, 2026
  3. Junio C HamanoAug 5, 2026
  4. Tian YuchenAug 6, 2026
  5. 1/3 environment: simplify repository config gettersTian Yuchen, Aug 5, 2026
  6. Junio C HamanoAug 5, 2026
  7. 3/3 environment: reorder variables in repo_config_values structureTian Yuchen, Aug 5, 2026
  8. Junio C HamanoAug 5, 2026
  9. Tian YuchenAug 6, 2026
  10. Junio C HamanoAug 6, 2026
  11. Tian YuchenAug 7, 2026
  12. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 6, 2026
  13. 1/3 environment: simplify repository config gettersTian Yuchen, Aug 6, 2026
  14. Junio C HamanoAug 6, 2026
  15. Tian YuchenAug 7, 2026
  16. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 6, 2026
  17. Junio C HamanoAug 6, 2026
  18. 3/3 environment: remove inaccurate repo_config_values commentsTian Yuchen, Aug 6, 2026
  19. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 7, 2026
  20. 1/3 environment: drop redundant NULL checks in config gettersTian Yuchen, Aug 7, 2026
  21. Patrick SteinhardtSep 11, 2026
  22. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 7, 2026
  23. 3/3 environment: remove inaccurate repo_config_values commentsTian Yuchen, Aug 7, 2026
  24. Patrick SteinhardtAug 7, 2026
  25. Junio C HamanoAug 7, 2026
  26. Patrick SteinhardtAug 10, 2026
  27. Junio C HamanoAug 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.