git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] environment: clean up repository config handling

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 7, 2026, 11:04 UTC
Message-ID
<anW7wHfUxYj9cj0P@pks.im>
In-Reply-To
<20260807085932.3958759-1-cat@malon.dev>
On Fri, Aug 07, 2026 at 04:59:29PM +0800, Tian Yuchen wrote:
Show 12 quoted lines
> Hi all,
> 
> This series contains several cleanup patches for repository configuration
> handling.
> 
> No functional changes are intended. The patches make the related code
> more consistent and easier to maintain by improving documentation,
> formatting, and the organization of repo_config_values.
> 
> RFC:
> If there are other small cleanups in this area that would be useful to
> include, suggestions are welcome.

Somewhat unrelated to this patch series, but I was wondering whether you plan to drop the limitation in `repo_config_values()` that requires that the passed-in repository is `the_repository`. This limitation is starting to create problems as more and more of our infrastructure is migrating into `struct repo_config_values`, so using a different repo than `the_repository` is starting to become harder and harder in our codebase.

Thanks!
Patrick
Previous: Tian YuchenNext: Junio C Hamano
Message 24 of 27 in “environment: clean up repository config handling”
  1. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 5, 2026
  2. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 5, 2026
  3. Junio C HamanoAug 5, 2026
  4. Tian YuchenAug 6, 2026
  5. 1/3 environment: simplify repository config gettersTian Yuchen, Aug 5, 2026
  6. Junio C HamanoAug 5, 2026
  7. 3/3 environment: reorder variables in repo_config_values structureTian Yuchen, Aug 5, 2026
  8. Junio C HamanoAug 5, 2026
  9. Tian YuchenAug 6, 2026
  10. Junio C HamanoAug 6, 2026
  11. Tian YuchenAug 7, 2026
  12. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 6, 2026
  13. 1/3 environment: simplify repository config gettersTian Yuchen, Aug 6, 2026
  14. Junio C HamanoAug 6, 2026
  15. Tian YuchenAug 7, 2026
  16. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 6, 2026
  17. Junio C HamanoAug 6, 2026
  18. 3/3 environment: remove inaccurate repo_config_values commentsTian Yuchen, Aug 6, 2026
  19. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 7, 2026
  20. 1/3 environment: drop redundant NULL checks in config gettersTian Yuchen, Aug 7, 2026
  21. Patrick SteinhardtSep 11, 2026
  22. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 7, 2026
  23. 3/3 environment: remove inaccurate repo_config_values commentsTian Yuchen, Aug 7, 2026
  24. Patrick SteinhardtAug 7, 2026
  25. Junio C HamanoAug 7, 2026
  26. Patrick SteinhardtAug 10, 2026
  27. Junio C HamanoAug 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.