git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] environment: clarify repository config getter documentation

From
Tian Yuchen <cat@malon.dev>
Date
Aug 5, 2026, 11:53 UTC
Message-ID
<20260805115342.3939931-3-cat@malon.dev>
In-Reply-To
<20260805115342.3939931-1-cat@malon.dev>

Update the comment above repository config getters to describe their common behavior.

The getters handle repositories that are not fully initialized by returning the corresponding default values.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
Signed-off-by: Tian Yuchen <cat@malon.dev>
---
 environment.h | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/environment.h b/environment.h
index e7ec5b0437..30678257b5 100644
--- a/environment.h
+++ b/environment.h
@@ -175,18 +175,13 @@ int git_default_core_config(const char *var, const char *value,
 			    const struct config_context *ctx, void *cb);
 
 /*
- * Getters for the `protect_hfs` and `protect_ntfs` fields of `struct repo_config_values`.
- * They check `repo->initialized` to prevent calling `repo_config_values()`
- * before the repository setup is fully complete or in non-git environments.
+ * Getters for configuration variables in `struct repo_config_values`.
+ * These functions handle uninitialized repositories or non-git
+ * environments by returning appropriate default values.
  */
 int repo_protect_hfs(struct repository *repo);
 int repo_protect_ntfs(struct repository *repo);
 
-/*
- * Getter for the `ignore_case` field of `struct repo_config_values`.
- * It checks `repo->initialized` to prevent calling repo_config_values()`
- * before the repository setup is fully complete or in non-git environments.
- */
 int repo_ignore_case(struct repository *repo);
 
 int repo_trust_executable_bit(struct repository *repo);
-- 
2.43.0
Previous: Tian YuchenNext: Junio C Hamano
Message 2 of 27 in “environment: clean up repository config handling”
  1. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 5, 2026
  2. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 5, 2026
  3. Junio C HamanoAug 5, 2026
  4. Tian YuchenAug 6, 2026
  5. 1/3 environment: simplify repository config gettersTian Yuchen, Aug 5, 2026
  6. Junio C HamanoAug 5, 2026
  7. 3/3 environment: reorder variables in repo_config_values structureTian Yuchen, Aug 5, 2026
  8. Junio C HamanoAug 5, 2026
  9. Tian YuchenAug 6, 2026
  10. Junio C HamanoAug 6, 2026
  11. Tian YuchenAug 7, 2026
  12. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 6, 2026
  13. 1/3 environment: simplify repository config gettersTian Yuchen, Aug 6, 2026
  14. Junio C HamanoAug 6, 2026
  15. Tian YuchenAug 7, 2026
  16. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 6, 2026
  17. Junio C HamanoAug 6, 2026
  18. 3/3 environment: remove inaccurate repo_config_values commentsTian Yuchen, Aug 6, 2026
  19. 0/3 environment: clean up repository config handlingTian Yuchen, Aug 7, 2026
  20. 1/3 environment: drop redundant NULL checks in config gettersTian Yuchen, Aug 7, 2026
  21. Patrick SteinhardtSep 11, 2026
  22. 2/3 environment: clarify repository config getter documentationTian Yuchen, Aug 7, 2026
  23. 3/3 environment: remove inaccurate repo_config_values commentsTian Yuchen, Aug 7, 2026
  24. Patrick SteinhardtAug 7, 2026
  25. Junio C HamanoAug 7, 2026
  26. Patrick SteinhardtAug 10, 2026
  27. Junio C HamanoAug 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.