git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] builtin/commit-graph: some small cleanups

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2026, 20:40 UTC
Message-ID
<xmqqv76l7e48.fsf@gitster.g>
In-Reply-To
<20261028-pks-commit-graph-cleanups-v1-0-c549344c363f@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 17 quoted lines
> Hi,
>
> I'm working into the direction of making commit-graphs pluggable so that
> backends can fully control where exactly commit-graphs are written to
> and read from. This patch series contains a couple of small preliminary
> cleanups.
>
> Most of the patches are rather uncontroversial, I'd assume. The only
> one that might raise some eyebrows is where I "fix" git-commit-graph(1)
> to only accept "--object-directory=" for subcommands instead of both as
> a command-global and subcommand option. I feel like this is quite a weird
> outlier, and it got in my way. In any case, I'd appreciate some extra
> thoughts on this.
>
> Thanks!
>
> Patrick

I read the first 4 steps and they all looked sensible. May come back to the remainder later this week if nobody beats me to it.

Thanks.
Show 18 quoted lines
>
> ---
> Patrick Steinhardt (7):
>       builtin/commit-graph: rename subcommand functions
>       builtin/commit-graph: drop declaration for `read_replace_refs`
>       builtin/commit-graph: get rid of `the_repository`
>       builtin/commit-graph: drop global "--object-dir=" switch
>       builtin/commit-graph: simplify how we wire up common options
>       builtin/commit-graph: de-globalize write options handling
>       builtin/commit-graph: de-globalize options handling
>
>  builtin/commit-graph.c | 131 +++++++++++++++++++++++++------------------------
>  1 file changed, 67 insertions(+), 64 deletions(-)
>
>
> ---
> base-commit: 37b3475fb530c14109211faca33716a173db61ed
> change-id: 20261028-pks-commit-graph-cleanups-d1dc30f3e05a
Previous: Mark C. Chu-CarrollNext: Junio C Hamano
Message 10 of 12 in “builtin/commit-graph: some small cleanups”
  1. 0/7 builtin/commit-graph: some small cleanupsPatrick Steinhardt, Oct 28, 2026
  2. 1/7 builtin/commit-graph: rename subcommand functionsPatrick Steinhardt, Oct 28, 2026
  3. 2/7 builtin/commit-graph: drop declaration for `read_replace_refs`Patrick Steinhardt, Oct 28, 2026
  4. 3/7 builtin/commit-graph: get rid of `the_repository`Patrick Steinhardt, Oct 28, 2026
  5. 4/7 builtin/commit-graph: drop global "--object-dir=" switchPatrick Steinhardt, Oct 28, 2026
  6. 5/7 builtin/commit-graph: simplify how we wire up common optionsPatrick Steinhardt, Oct 28, 2026
  7. 6/7 builtin/commit-graph: de-globalize write options handlingPatrick Steinhardt, Oct 28, 2026
  8. 7/7 builtin/commit-graph: de-globalize options handlingPatrick Steinhardt, Oct 28, 2026
  9. Mark C. Chu-CarrollOct 28, 2026
  10. Junio C HamanoOct 28, 2026
  11. Junio C HamanoOct 28, 2026
  12. Karthik NayakOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.