From: Junio C Hamano Date: Wed, 28 Oct 2026 20:40:39 GMT Subject: Re: [PATCH 0/7] builtin/commit-graph: some small cleanups Message-ID: In-Reply-To: <20261028-pks-commit-graph-cleanups-v1-0-c549344c363f@pks.im> Patrick Steinhardt writes: > Hi, > > I'm working into the direction of making commit-graphs pluggable so that > backends can fully control where exactly commit-graphs are written to > and read from. This patch series contains a couple of small preliminary > cleanups. > > Most of the patches are rather uncontroversial, I'd assume. The only > one that might raise some eyebrows is where I "fix" git-commit-graph(1) > to only accept "--object-directory=" for subcommands instead of both as > a command-global and subcommand option. I feel like this is quite a weird > outlier, and it got in my way. In any case, I'd appreciate some extra > thoughts on this. > > Thanks! > > Patrick I read the first 4 steps and they all looked sensible. May come back to the remainder later this week if nobody beats me to it. Thanks. > > --- > Patrick Steinhardt (7): > builtin/commit-graph: rename subcommand functions > builtin/commit-graph: drop declaration for `read_replace_refs` > builtin/commit-graph: get rid of `the_repository` > builtin/commit-graph: drop global "--object-dir=" switch > builtin/commit-graph: simplify how we wire up common options > builtin/commit-graph: de-globalize write options handling > builtin/commit-graph: de-globalize options handling > > builtin/commit-graph.c | 131 +++++++++++++++++++++++++------------------------ > 1 file changed, 67 insertions(+), 64 deletions(-) > > > --- > base-commit: 37b3475fb530c14109211faca33716a173db61ed > change-id: 20261028-pks-commit-graph-cleanups-d1dc30f3e05a