Re: [PATCH 0/7] builtin/commit-graph: some small cleanups
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Oct 29, 2026, 12:55 UTC
- Message-ID
- <CAOLa=ZRVhZjv3yXA76wK+fZ0o=FrwScHcT3=xJOOgYvjG6cSiQ@mail.gmail.com>
- In-Reply-To
- <xmqqv76l7e48.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > >> Hi, >> >> I'm working into the direction of making commit-graphs pluggable so that >> backends can fully control where exactly commit-graphs are written to >> and read from. This patch series contains a couple of small preliminary >> cleanups. >> >> Most of the patches are rather uncontroversial, I'd assume. The only >> one that might raise some eyebrows is where I "fix" git-commit-graph(1) >> to only accept "--object-directory=" for subcommands instead of both as >> a command-global and subcommand option. I feel like this is quite a weird >> outlier, and it got in my way. In any case, I'd appreciate some extra >> thoughts on this. >> >> Thanks! >> >> Patrick > > I read the first 4 steps and they all looked sensible. May come > back to the remainder later this week if nobody beats me to it. > > Thanks. >
I didn't beat you to it, but I too have nothing to object here, everything looks to be in order :)