Re: [PATCH 0/7] builtin/commit-graph: some small cleanups
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 28, 2026, 21:28 UTC
- Message-ID
- <xmqq8q3h7bvp.fsf@gitster.g>
- In-Reply-To
- <xmqqv76l7e48.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> I read the first 4 steps and they all looked sensible. May come > back to the remainder later this week if nobody beats me to it. > > Thanks.
As to the rest, quite honestly, [6/7] and [7/7] were "Meh", even though I do not think they hurt [*].
All the rest looked good to me.
[Footnote]
* Unless these things are lifted out of bulitin/* hierarchy, there is no strong reason to avoid relying on global variables or even the_repository. Once we move things out of there to make them truly reusable, these things start to matter, but until then...