git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] builtin/commit-graph: some small cleanups

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2026, 21:28 UTC
Message-ID
<xmqq8q3h7bvp.fsf@gitster.g>
In-Reply-To
<xmqqv76l7e48.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> I read the first 4 steps and they all looked sensible.  May come
> back to the remainder later this week if nobody beats me to it.
>
> Thanks.

As to the rest, quite honestly, [6/7] and [7/7] were "Meh", even though I do not think they hurt [*].

All the rest looked good to me.
[Footnote]
 * Unless these things are lifted out of bulitin/* hierarchy, there
   is no strong reason to avoid relying on global variables or even
   the_repository.  Once we move things out of there to make them
   truly reusable, these things start to matter, but until then...
Previous: Junio C HamanoNext: Karthik Nayak
Message 11 of 12 in “builtin/commit-graph: some small cleanups”
  1. 0/7 builtin/commit-graph: some small cleanupsPatrick Steinhardt, Oct 28, 2026
  2. 1/7 builtin/commit-graph: rename subcommand functionsPatrick Steinhardt, Oct 28, 2026
  3. 2/7 builtin/commit-graph: drop declaration for `read_replace_refs`Patrick Steinhardt, Oct 28, 2026
  4. 3/7 builtin/commit-graph: get rid of `the_repository`Patrick Steinhardt, Oct 28, 2026
  5. 4/7 builtin/commit-graph: drop global "--object-dir=" switchPatrick Steinhardt, Oct 28, 2026
  6. 5/7 builtin/commit-graph: simplify how we wire up common optionsPatrick Steinhardt, Oct 28, 2026
  7. 6/7 builtin/commit-graph: de-globalize write options handlingPatrick Steinhardt, Oct 28, 2026
  8. 7/7 builtin/commit-graph: de-globalize options handlingPatrick Steinhardt, Oct 28, 2026
  9. Mark C. Chu-CarrollOct 28, 2026
  10. Junio C HamanoOct 28, 2026
  11. Junio C HamanoOct 28, 2026
  12. Karthik NayakOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.