Re: [PATCH v16 0/7] config commit verbose

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2016, 16:01 UTC
Message-ID: <xmqqtwi7xlsc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160509142825.GB9552@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I guess I do not really consider the template content to be the primary
> thing the command is doing. It is subjective, though. I don't feel
> strongly enough to keep discussing it if other people don't agree.

I just see the primary thing of what "commit -e" does is to help users edit their log message (and view "-v" as giving more helping), but I do agree with you that this is very subjective.

If we had these as either in broken-down form ("--show-diff", "--show-diffstat", and "--show-untracked") or just a single "--show-extra-info" option when we did the feature in the very beginning, I do not think I'd feel that "--show-*" option(s) should be renamed/redone to "--verbose". So personally, my subjective judgment is "'--verbose' and '--show-diff' would have been equally valid, and it is OK to let whichever came first squat on the feature."