Re: [PATCH v16 0/7] config commit verbose

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 6, 2016, 05:30 UTC
Message-ID: <CAPig+cQO3W4WthHstrVFWziU2RAuNyEzeQwBEyDXG8dghRjECQ@mail.gmail.com>
In-Reply-To: <xmqq7ff8b99q.fsf@gitster.mtv.corp.google.com>

On Thu, May 5, 2016 at 3:21 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Pranit Bauva <pranit.bauva@gmail.com> writes:
>> This series of patches add a configuration variable for verbose in
>> git-commit.
>>
>> Changes wrt v15:
>>  * Remove the previous patch 7/7 and split the tests. Include one in
>>    initial patch 6/7. The other one is introduced in a separate commit
>>    after 4/7.
>>  * Include tests in patch 3/6 for --no-quiet without -q, multiple verbose,
>>    --no-verbose with -v as suggested by Eric Sunshine
>
> Thanks for a pleasant read.  Modulo minor readability nits I sent
> separately on 7/7, this looked good.

Agreed, this version was a more pleasant and coherent read than previous ones.

Considering that this series is already at v16 and the 7/7 review comments were very minor, I'd be fine seeing this series land as-is, rather than expecting v17.