Re: [PATCH v16 0/7] config commit verbose

From: Pranit Bauva <pranit.bauva@gmail.com>
Date: May 6, 2016, 16:16 UTC
Message-ID: <CAFZEwPPkBcdupLktJ=ystnx_1y7Mv+U436Jn9JBUCrvkt+t8tQ@mail.gmail.com>
In-Reply-To: <CACBZZX5ssO2EiuxR7wotGowMaPhtioaJVSDpQDUwUkv1rLJJWw@mail.gmail.com>

[+cc:git@vger.kernel.org] Because its an interesting fact to be shared which isn't covered elsewhere.

On Fri, May 6, 2016 at 2:53 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 5 quoted lines

> Sending this privately since it's probably covered elsewhere. With
> this, if I set the option will "reword" in git rebase -i show me the
> patch?
>
> If so: awesome.

Yes, git rebase -i will show the diff in 'reword' if commit.verbose is set to true or a value greater than 0.

I dug further in git-rebase--interactive.sh I could find appearances of "git commit --amend" but I was unable to find appearances of "COMMIT_EDITMSG". If COMMIT_EDITMSG was coming into picture, the commit.verbose could not affect it. And that is not the case.

I guess this would be a desirable trait for most of the consumers of commit.verbose (like Ævar) so there would not be a need to suppress.

Regards, Pranit Bauva