Re: [PATCH v1 1/2] git ls-files: text=auto eol=lf is supported in Git 2.10

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2016, 20:38 UTC
Message-ID: <xmqqtwe8lh3d.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160825155257.28968-1-tboegi@web.de>

tboegi@web.de writes:

Show 6 quoted lines

> From: Torsten Bögershausen <tboegi@web.de>
>
> The man page for `git ls-files --eol` mentions the combination
> of text attributes "text=auto eol=lf" or "text=auto eol=crlf" as not
> supported yet, but may be in the future.
> Now they are supported

Thanks. I'll finish the sentence with a full-stop here ;-).

Show 17 quoted lines

>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---
>  Documentation/git-ls-files.txt | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
> index 078b556..0d933ac 100644
> --- a/Documentation/git-ls-files.txt
> +++ b/Documentation/git-ls-files.txt
> @@ -159,8 +159,7 @@ not accessible in the working tree.
>  +
>  <eolattr> is the attribute that is used when checking out or committing,
>  it is either "", "-text", "text", "text=auto", "text eol=lf", "text eol=crlf".
> -Note: Currently Git does not support "text=auto eol=lf" or "text=auto eol=crlf",
> -that may change in the future.
> +Since Git 2.10 "text=auto eol=lf" and "text=auto eol=crlf" are supported.

It may be a good idea to have this for a while. Having this sentence would only help those who have been dissuaded by the existing Note by telling them that the limitation is no longer there, but that will quickly become unnecessary.

We'd eventually want to remove this sentence. I wonder if it is a better alternative to just remove the Note without adding new text, though.

>  Both the <eolinfo> in the index ("i/<eolinfo>")
>  and in the working tree ("w/<eolinfo>") are shown for regular files,