Re: [PATCH v1 1/2] t0027: Correct raciness in NNO test

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2016, 20:37 UTC
Message-ID: <xmqqpopbkrya.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160813211805.GA10624@tb-raspi>

Torsten Bögershausen <tboegi@web.de> writes:

Show 6 quoted lines

> Looking at t0027, it turns out that the changes in the test matrix done in 1/2
> are reverted in 2/2.
> This is not a good thing.
> Either (a) they should be marked as test_expect_failure in 1/2 and
> corrected in 2/2,
> or (b) 1/2 and 2/2 are squashed together and the noise in t0027 is minimal.

Probably (a) is a bit more kosher and useful when somebody wants to inspect the history of the test ("the test was flaky and that hid a few bugs, but we fix the timing-dependency which exposes the bugs" in 1/2, "this is the fix for the bug that the previous one exposed" in 2/2). (b) might be a bit less work, though.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.