Re: t0027 racy?

From: Torsten Bögershausen <tboegi@web.de>
Date: Aug 9, 2016, 21:28 UTC
Message-ID: <20160809212802.GA4132@tb-raspi>
In-Reply-To: <20160809132744.kjzmkgt2qiugeolj@sigill.intra.peff.net>

Show 14 quoted lines

>   git -c core.autocrlf=$crlf add $fname >"${pfx}_$f.err" 2>&1
> 
> would make more sense. We _know_ that we have to do convert_to_git() in
> that step because the content is changed. And then you can ignore the
> warnings from "git commit" (which are racy), or you can simply commit as
> a whole later, as some other loops do.
> 
> But like Dscho, I do not actually understand what this test is checking.
> The function is called commit_chk_wrnNNO(), so perhaps you really are
> interested in what "commit" has to say. But IMHO that is not an
> interesting test. We know that if it has to read the content from disk,
> it will call convert_to_git(), which is the exact same code path used by
> "git add". So I do not understand what it is accomplishing to make a
> commit at all here.

It seems as if the test has been written without understanding the raciness. It should commit files with different line endings on top of a file with mixed line endings. The warning should be checked (and here "git add" can be used, or the file can be commited directly). I'm not sure why the test ended up in doing both.

However, doing it the right way triggers a bug in convert.c, (some warnings are missing, so I need some days to come up with a proper patch)

Thanks for reporting & digging.