Re: t0027 racy?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 9, 2016, 11:27 UTC
Message-ID: <alpine.DEB.2.20.1608091325430.5786@virtualbox>
In-Reply-To: <20160809070345.rpdxjvmb6ujeefhv@sigill.intra.peff.net>

Hi Peff,

On Tue, 9 Aug 2016, Jeff King wrote:

Show 15 quoted lines

> And indeed, this seems to fix it for me (at least it has been running in
> a 16-way loop for 5 minutes, whereas before it died after 30 seconds or
> so):
> 
> diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> index 2860d2d..9f057ff 100755
> --- a/t/t0027-auto-crlf.sh
> +++ b/t/t0027-auto-crlf.sh
> @@ -120,6 +120,7 @@ commit_chk_wrnNNO () {
>  		cp $f $fname &&
>  		printf Z >>"$fname" &&
>  		git -c core.autocrlf=$crlf add $fname 2>/dev/null &&
> +		touch $fname && # ensure index raciness
>  		git -c core.autocrlf=$crlf commit -m "commit_$fname" $fname >"${pfx}_$f.err" 2>&1
>  	done

I will test this patch as soon as my poor machine has less work.

> I'm not sure if there is a more elegant solution, though (for instance,
> why not collect the output from "git add", which should have the same
> warning, I would think).

That should work, too. I am a bit overwhelmed with t0027, though, I do not really understand what is going on. It tests *so many* things, and in no test case is it clear to me what it tests and what it expects let alone why those expectations make sense.

Ciao, Dscho