Re: [PATCH] git-send-email: Cc more people

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 20, 2018, 00:03 UTC
Message-ID: <xmqqtvs6d9r6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <646938104.13100.1524141300699.JavaMail.zimbra@efficios.com>

Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:

Show 10 quoted lines

>>> I'd further say that these new CC-sources should be disabled by
>>> default and made opt-in to avoid surprising existing users.
>> 
>> But I disagree with this.  The current behaviour is surprising to
>> existing users, to the point where people are writing their own scripts
>> to replace git send-email (which seems crazy to me).
>
> We could perhaps go with a whitelist approach. The four
> main match I would be tempted to add are: Acked-by, Reported-by,
> Reviewed-by, and Tested-by.

A tool that suddenly starts sending e-mails to more addresses without letting the end-users know when and why the change in behaviour happened is a source of irritated "somebody made a stupid change to git-send-email without telling us that caused unwanted e-mails sent to unexpected places and embarrassed me" bug reports. I do agree with a whitelist approach from that point of view, and in the initial rollout of the feature, that whitelist should be limited to what we already send out.

The users who learn about this new feature can opt into whitelisting the common 4 above before we enable them by default. FWIW, I personally think these will be a sensible default (in addition to what we already Cc). I however prefer an approach to introduce these more gradually.