git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-send-email: Cc more people

From
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date
Apr 20, 2018, 15:27 UTC
Message-ID
<666133236.13971.1524238059705.JavaMail.zimbra@efficios.com>
In-Reply-To
<xmqqtvs6d9r6.fsf@gitster-ct.c.googlers.com>
----- On Apr 19, 2018, at 8:03 PM, Junio C Hamano gitster@pobox.com wrote:
Show 27 quoted lines
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
> 
>>>> I'd further say that these new CC-sources should be disabled by
>>>> default and made opt-in to avoid surprising existing users.
>>> 
>>> But I disagree with this.  The current behaviour is surprising to
>>> existing users, to the point where people are writing their own scripts
>>> to replace git send-email (which seems crazy to me).
>>
>> We could perhaps go with a whitelist approach. The four
>> main match I would be tempted to add are: Acked-by, Reported-by,
>> Reviewed-by, and Tested-by.
> 
> A tool that suddenly starts sending e-mails to more addresses
> without letting the end-users know when and why the change in
> behaviour happened is a source of irritated "somebody made a stupid
> change to git-send-email without telling us that caused unwanted
> e-mails sent to unexpected places and embarrassed me" bug reports.
> I do agree with a whitelist approach from that point of view, and in
> the initial rollout of the feature, that whitelist should be limited
> to what we already send out.
> 
> The users who learn about this new feature can opt into whitelisting
> the common 4 above before we enable them by default.  FWIW, I
> personally think these will be a sensible default (in addition to
> what we already Cc).  I however prefer an approach to introduce
> these more gradually.
Sure, introducing changes like this needs to be done gradually.
Thanks!
Mathieu
-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
Previous: Junio C Hamano
Message 9 of 9 in “git-send-email: Cc more people”
  1. git-send-email: Cc more peopleMatthew Wilcox, Apr 18, 2018
  2. Steven RostedtApr 18, 2018
  3. Mathieu DesnoyersApr 18, 2018
  4. Ævar Arnfjörð BjarmasonApr 18, 2018
  5. Junio C HamanoApr 18, 2018
  6. Matthew WilcoxApr 19, 2018
  7. Mathieu DesnoyersApr 19, 2018
  8. Junio C HamanoApr 20, 2018
  9. Mathieu DesnoyersApr 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.