Re: [PATCH] git-send-email: Cc more people

From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Apr 18, 2018, 17:25 UTC
Message-ID: <1481207245.12764.1524072308610.JavaMail.zimbra@efficios.com>
In-Reply-To: <20180418103339.30bae9bc@gandalf.local.home>

----- On Apr 18, 2018, at 10:33 AM, rostedt rostedt@goodmis.org wrote:

Show 15 quoted lines

> On Wed, 18 Apr 2018 07:05:03 -0700
> Matthew Wilcox <willy@infradead.org> wrote:
> 
>> From: Matthew Wilcox <mawilcox@microsoft.com>
>> 
>> Several of my colleagues (and myself) have expressed surprise and
>> annoyance that git-send-email doesn't automatically pick up people who
>> are listed in patches as Reported-by: or Reviewed-by: or ... many other
>> tags that would seem (to us) to indicate that person might be interested.
>> This patch to git-send-email tries to pick up all Foo-by: tags.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Note, this is one of the reasons I still use quilt to send my email.
> I've modified my quilt scripts to do what Matthew does here below.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

I find it really surprising and unexpected that people listed as "Reviewed-by" don't end up being CC'd.

Thanks,

Mathieu

Show 20 quoted lines

> 
> -- Steve
> 
> 
>> 
>> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>> 
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index 2fa7818ca..926815329 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -1665,7 +1665,7 @@ foreach my $t (@files) {
>>  	# Now parse the message body
>>  	while(<$fh>) {
>>  		$message .=  $_;
>> -		if (/^(Signed-off-by|Cc): (.*)/i) {
>> +		if (/^([A-Z-a-z]*-by|Cc): (.*)/i) {
>>  			chomp;
>>  			my ($what, $c) = ($1, $2);
> >  			# strip garbage for the address we'll use:

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com