Re: [PATCH] git-send-email: Cc more people

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 18, 2018, 21:21 UTC
Message-ID: <xmqqr2ncgqhl.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <87tvs8e174.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 13 quoted lines

> But IMO this patch is really lacking a few things before being ready:
>
> 1. You have no tests for this. See t/t9001-send-email.sh for examples,
> ...
> 2. Just a few lines down from your quoted hunk we have this:
> ... code about $supress_cc{<token>} ...
>    Your change should at least describe why those aren't being updated,
>    but probably we should add some other command-line option for
>    ignoring these wildcards, e.g. --[no-]wildcard-by-cc=reviewed
>    --[no-]wildcard-by-cc=seen etc, and we can make --[no-]signed-off-by
>    a historical alias for --[no-]wildcard-by-cc=signed-off.
> 3. Ditto all the documentation in "man git-send-email" about
> ...

Thanks, I agree that 2. (the lack of suppression) is a showstopper. I'd further say that these new CC-sources should be disabled by default and made opt-in to avoid surprising existing users.

One thing we also need to be very careful about is that some of the fields may not even have an e-mail address. We can expect that S-o-b and Cc would be of form "human readable name <email@addre.ss>" by their nature, but it is perfectly fine to write only human readable name without address on random lines like "suggeted-by" and "helped-by". There needs a way for the end-user to avoid using data found on such lines as if they are valid e-mail addresses.