Re: [RFC PATCH 2/3] usage: prefix all lines in `vreportf()`, not just the first
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 29, 2018, 05:50 UTC
- Message-ID
- <xmqqtvqrggdt.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAN0heSq1y3XibCFDYsae5b6jmzZOzcLHT4atCZ+KCb4dL5As0g@mail.gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
Show 7 quoted lines
>> - allow callers to align 1st prefix (e.g. "error: ") with the >> leading indent for the second and subsequent lines by passing the >> second prefix with appropriate display width. > > I suspect this second prefix would always consist of > strlen(first_prefix) spaces? We should be able to construct it on the > fly, without any need for manual counting and human mistakes.
I wouldn't be so bold to claim that, given especially that we are talking about i18n/l10n where byte count, character count and display width are all different even on a terminal with fixed-width font.