Re: What's cooking in git.git (May 2018, #02; Thu, 17)
- From
Stefan Beller <sbeller@google.com>
- Date
- May 21, 2018, 17:36 UTC
- Message-ID
- <CAGZ79kau121ZnwYVf0tFNvc1_G8Fxz55apgqLeok7Z8vQFZZdg@mail.gmail.com>
- In-Reply-To
- <20180521015739.GE652292@genre.crustytoothpaste.net>
Show 11 quoted lines
>> Many tests hardcode the raw object names, which would change once >> we migrate away from SHA-1. While some of them must test against >> exact object names, most of them do not have to use hardcoded >> constants in the test. The latter kind of tests have been updated >> to test the moral equivalent of the original without hardcoding the >> actual object names. >> >> Will merge to 'next'. > > I think there was one minor change Stefan wanted out of this series. > I'll send a reroll (and tbdiff) with just that change.
I was just unsure how we treat [e]grep in our test suite, so I asked questions out of sheer curiosity. I have no objections to the change made, though.
Thanks!