Re: jk/branch-l-0-deprecation (was Re: What's cooking in git.git (May 2018, #02; Thu, 17))

From: Jeff King <peff@peff.net>
Date: May 24, 2018, 19:22 UTC
Message-ID: <20180524192214.GA21535@sigill.intra.peff.net>
In-Reply-To: <1527174618.10589.4.camel@gmail.com>

On Thu, May 24, 2018 at 08:40:18PM +0530, Kaartic Sivaraam wrote:

Show 14 quoted lines

> > On the other hand, I'm not sure this is that big a deal. The point of
> > the deprecation warning is to catch people who are actually trying to
> > use "-l" as "--create-reflog", and that case does not page. The people
> > doing "git branch -l" are actually getting what they want eventually,
> > which is to turn it into "--list". In the interim step where it becomes
> > an unknown option, they'll get a hard error. 
> 
> I just thought we wouldn't want to surprise/confuse users who try to
> use "git branch -l" with the warning message about "create reflog"
> along-side the list of branches. That would just add to the confusion.
> So, I thought we should error out when users do "git branch -l"
> instead. Something like the following should help us prevent "git
> branch -l" from listing branch names and might also prevent the
> confusion.

Yeah, I think that's just a more extreme version of the current plan (it turns it immediately into a hard error instead of warning for a while). If we just make the warning easier to see in the paged case, I think that makes the current plan fine.

I'll wrap up the patch I sent earlier.

-Peff