Re: [PATCH] branch: issue "-l" deprecation warning after pager starts
- From
Jeff King <peff@peff.net>
- Date
- May 31, 2018, 05:44 UTC
- Message-ID
- <20180531054451.GB17344@sigill.intra.peff.net>
- In-Reply-To
- <xmqq7enlg8ov.fsf@gitster-ct.c.googlers.com>
On Wed, May 30, 2018 at 11:48:32AM +0900, Junio C Hamano wrote:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes:
>
> >> - if (list) {
> >> - warning("the '-l' option is an alias for '--create-reflog' and");
> >> - warning("has no effect in list mode. This option will soon be");
> >> - warning("removed and you should omit it (or use '--list' instead).");
> >> - } else {
> >> - warning("the '-l' alias for '--create-reflog' is deprecated;");
> >> - warning("it will be removed in a future version of Git");
> >> - }
> >> - }
> >> -
> >
> > Oh, and did we want to mark these for translation on the step 0 branch?
> > Obviously that would impact this hunk.
>
> I was hoping that we can settle the "multi-line message translation
> that can potentially result in different number of lines" issue
> before we have to mark the above for translation ;-)Yeah, right after saying that I realized it would create horrible translation-lego. I agree we should punt for now.
-Peff