Re: [PATCH 1/2] pkt-line: fix declaration of `set_packet_header()`

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2019, 04:28 UTC
Message-ID: <xmqqtvdv3twf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190516034220.GE4596@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 20 quoted lines

> On Thu, May 16, 2019 at 11:24:25AM +0900, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> >> lacked the "const" for that reason, but apparently some compilers
>> >> complain about the parameter type mismatch.
>> >
>> > We could be more explicit, as we know exactly that it is MS Visual C 2017
>> > that is complaining.
>> 
>> We could be, but I do not see a point of shaming one particular
>> compiler vendor.
>
> I'd slightly disagree. If 10 years from now we decide that MSVC is not a
> supported compiler anymore, that information would be useful for
> somebody digging into the history to say "ah, we can probably use this
> pattern once more". I say probably because while it was the only
> complainer, once the pattern is removed we wouldn't know if anybody in
> the interim _would_ have complained. But it still seems like something
> that _could_ be useful to an archaeologist in the future.

OK. I do not have problem with "... apparently some compilers (e.g. MS Visual C 2017) complain about ...".

I just thought MS folks would mind that; if they do want to see the name of their compiler in the description, I am fine, too.

Thanks.