Re: [PATCH 1/2] pkt-line: fix declaration of `set_packet_header()`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 15, 2019, 01:42 UTC
- Message-ID
- <xmqqa7fo8pdg.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190514144305.GA28530@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> I do have a slight preference for going the _other_ way. There is no > need to mark the parameter as const in the definition. It is passed by > value, so nobody except the function body cares either way. And we have > many function bodies where value-passed parameters (or local variables!) > are not marked as const, even though they are only assigned to once.
That would be more like this patch, then?
-- >8 -- Subject: pkt-line: drop 'const'-ness of a param to set_packet_header()
The fact that the incoming parameter is used as read-only in the fuction is an implementation detail that the callers should not have to know, and the prototype defined for the function in pkt-line.h lacked the "const" for that reason, but apparently some compilers complain about the parameter type mismatch.
Let's squelch it by removing the "const" that is pointless for a small function like this, which would not help optimizing compilers nor reading humans that much.
Noticed-by: Johannes Schindelin <johannes.schindelin@gmx.de> Helped-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- pkt-line.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c index c9ed780d0b..a0e87b1e81 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -119,7 +119,7 @@ void packet_buf_delim(struct strbuf *buf) strbuf_add(buf, "0001", 4); } -void set_packet_header(char *buf, const int size) +void set_packet_header(char *buf, int size) { static char hexchar[] = "0123456789abcdef";