Re: [PATCH 1/2] pkt-line: fix declaration of `set_packet_header()`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 17, 2019, 18:54 UTC
Message-ID: <nycvar.QRO.7.76.6.1905172051560.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq36lf5e7a.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 16 May 2019, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> lacked the "const" for that reason, but apparently some compilers
> >> complain about the parameter type mismatch.
> >
> > We could be more explicit, as we know exactly that it is MS Visual C 2017
> > that is complaining.
>
> We could be, but I do not see a point of shaming one particular
> compiler vendor.

I agree that there is no point in shaming (in fact, there is a lot of harm in shaming, everybody who intentionally shames other people needs to have a look at https://psycnet.apa.org/doiLanding?doi=10.1037%2Femo0000542 to find out what harm they are doing).

That is why I suggested to be more explicit, not to shame.

Of course, that illustrates that I apparently think a lot differently about this issue: in contrast to you, I do not think that MSVC does a particularly bad thing here, even if it dares disagree with GCC. :-)

Ciao, Dscho