git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/4] builtin/stash: provide a way to export stashes to a ref

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2022, 23:05 UTC
Message-ID
<xmqqtubf59dz.fsf@gitster.g>
In-Reply-To
<20220329214941.2018609-4-sandals@crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 31 quoted lines
> +static int do_export_stash(const char *ref, size_t argc, const char **argv)
> +{
> +	struct object_id base;
> +	struct object_context unused;
> +	struct commit *prev;
> +	struct object_id *items = NULL;
> +	int nitems = 0, nalloc = 0;
> +	int res = 0;
> +	struct strbuf revision;
> +	const char *author, *committer;
> +
> +	/*
> +	 * This is an arbitrary, fixed date, specifically the one used by git
> +	 * format-patch.  The goal is merely to produce reproducible output.
> +	 */
> +	prepare_fallback_ident("git stash", "git@stash");
> +	author = fmt_ident("git stash", "git@stash", WANT_BLANK_IDENT, "2001-09-17T00:00:00Z", 0);
> +	committer = fmt_ident("git stash", "git@stash", WANT_BLANK_IDENT, "2001-09-17T00:00:00Z", 0);
> +
> +	/* First, we create a single empty commit. */
> +	if (commit_tree_extended(NULL, 0, the_hash_algo->empty_tree, NULL, &base, author, committer, NULL, NULL))
> +		return error(_("unable to write base commit"));
> +
> +	prev = lookup_commit_reference(the_repository, &base);
> +
> +	if (argc) {
> +		/*
> +		 * Find each specified stash, and load data into the array.
> +		 */
> +		for (int i = 0; i < argc; i++) {
> +			ALLOC_GROW_BY(items, nitems, 1, nalloc);
Documentation/CodingGuidelines still says this
 - Declaring a variable in the for loop "for (int i = 0; i < 10; i++)"
   is still not allowed in this codebase.

We have been experimenting since we merged 44ba10d6 (revision: use C99 declaration of variable in for() loop, 2021-11-14) at 5a4069a1 (Merge branch 'jc/c99-var-decl-in-for-loop', 2021-12-21), which is shipped as a part of v2.35.0 just a few months ago.

Let's not add more until we are sure that we do not have to revert 44ba10d6 (revision: use C99 declaration of variable in for() loop, 2021-11-14) to limit the potential damage, especially when it is so easy to do so.

Just declare "int i" at the beginning of the funcion and keep reusing it would be fine here.

Previous: brian m. carlsonNext: brian m. carlson
Message 34 of 76 in “Importing and exporting stashes to refs”
  1. 0/6 Importing and exporting stashes to refsbrian m. carlson, Mar 10, 2022
  2. 2/6 builtin/stash: fill in all commit databrian m. carlson, Mar 10, 2022
  3. Junio C HamanoMar 16, 2022
  4. 1/6 builtin/stash: factor out generic function to look up stash infobrian m. carlson, Mar 10, 2022
  5. 3/6 object-name: make get_oid quietly return an errorbrian m. carlson, Mar 10, 2022
  6. Junio C HamanoMar 16, 2022
  7. Drew StoleeMar 16, 2022
  8. brian m. carlsonMar 16, 2022
  9. 4/6 builtin/stash: provide a way to export stashes to a refbrian m. carlson, Mar 10, 2022
  10. Ævar Arnfjörð BjarmasonMar 11, 2022
  11. Phillip WoodMar 14, 2022
  12. Phillip WoodMar 15, 2022
  13. brian m. carlsonMar 16, 2022
  14. C99 %zu support (on MSVC) (was: [PATCH 4/6] builtin/stash: provide a way to export stashes to a ref)Ævar Arnfjörð Bjarmason, Mar 18, 2022
  15. Phillip WoodMar 18, 2022
  16. Johannes SchindelinMar 24, 2022
  17. ssize_t portability (was: [PATCH 4/6] builtin/stash: provide a way to export stashes to a ref)Ævar Arnfjörð Bjarmason, Mar 18, 2022
  18. Junio C HamanoMar 16, 2022
  19. 6/6 doc: add stash export and import to docsbrian m. carlson, Mar 10, 2022
  20. Junio C HamanoMar 16, 2022
  21. Junio C HamanoMar 16, 2022
  22. 5/6 builtin/stash: provide a way to import stashes from a refbrian m. carlson, Mar 10, 2022
  23. Junio C HamanoMar 16, 2022
  24. brian m. carlsonMar 16, 2022
  25. Junio C HamanoMar 10, 2022
  26. brian m. carlsonMar 10, 2022
  27. Junio C HamanoMar 10, 2022
  28. brian m. carlsonMar 10, 2022
  29. 0/4 Importing and exporting stashes to refsbrian m. carlson, Mar 29, 2022
  30. 2/4 builtin/stash: factor out revision parsing into a functionbrian m. carlson, Mar 29, 2022
  31. 1/4 object-name: make get_oid quietly return an errorbrian m. carlson, Mar 29, 2022
  32. 4/4 builtin/stash: provide a way to import stashes from a refbrian m. carlson, Mar 29, 2022
  33. 3/4 builtin/stash: provide a way to export stashes to a refbrian m. carlson, Mar 29, 2022
  34. Junio C HamanoMar 30, 2022
  35. brian m. carlsonMar 30, 2022
  36. Ævar Arnfjörð BjarmasonMar 31, 2022
  37. Junio C HamanoMar 31, 2022
  38. brian m. carlsonApr 5, 2022
  39. Ævar Arnfjörð BjarmasonApr 6, 2022
  40. Junio C HamanoApr 6, 2022
  41. Ævar Arnfjörð BjarmasonMar 31, 2022
  42. brian m. carlsonApr 5, 2022
  43. Junio C HamanoMar 31, 2022
  44. Ævar Arnfjörð BjarmasonMar 31, 2022
  45. 0/4 Importing and exporting stashes to refsbrian m. carlson, Apr 3, 2022
  46. 1/4 object-name: make get_oid quietly return an errorbrian m. carlson, Apr 3, 2022
  47. 2/4 builtin/stash: factor out revision parsing into a functionbrian m. carlson, Apr 3, 2022
  48. Phillip WoodApr 4, 2022
  49. 4/4 builtin/stash: provide a way to import stashes from a refbrian m. carlson, Apr 3, 2022
  50. Ævar Arnfjörð BjarmasonApr 4, 2022
  51. brian m. carlsonApr 5, 2022
  52. Ævar Arnfjörð BjarmasonApr 6, 2022
  53. 3/4 builtin/stash: provide a way to export stashes to a refbrian m. carlson, Apr 3, 2022
  54. Ævar Arnfjörð BjarmasonApr 4, 2022
  55. Junio C HamanoApr 4, 2022
  56. Junio C HamanoApr 4, 2022
  57. Ævar Arnfjörð BjarmasonApr 4, 2022
  58. brian m. carlsonApr 5, 2022
  59. 0/4 Importing and exporting stashes to refsbrian m. carlson, Apr 7, 2022
  60. 3/4 builtin/stash: provide a way to export stashes to a refbrian m. carlson, Apr 7, 2022
  61. Ævar Arnfjörð BjarmasonApr 13, 2022
  62. Ævar Arnfjörð BjarmasonApr 13, 2022
  63. Ævar Arnfjörð BjarmasonApr 13, 2022
  64. 2/4 builtin/stash: factor out revision parsing into a functionbrian m. carlson, Apr 7, 2022
  65. 1/4 object-name: make get_oid quietly return an errorbrian m. carlson, Apr 7, 2022
  66. 4/4 builtin/stash: provide a way to import stashes from a refbrian m. carlson, Apr 7, 2022
  67. Jonathan TanApr 12, 2022
  68. brian m. carlsonApr 13, 2022
  69. Jonathan TanApr 13, 2022
  70. Ævar Arnfjörð BjarmasonApr 13, 2022
  71. Jonathan TanApr 13, 2022
  72. Junio C HamanoApr 13, 2022
  73. brian m. carlsonApr 13, 2022
  74. Junio C HamanoApr 13, 2022
  75. Ævar Arnfjörð BjarmasonApr 13, 2022
  76. Ævar Arnfjörð BjarmasonApr 13, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.