Re: [PATCH v4 4/4] builtin/stash: provide a way to import stashes from a ref

From: Jonathan Tan <jonathantanmy@google.com>
Date: Apr 13, 2022, 19:14 UTC
Message-ID: <20220413191421.984299-1-jonathantanmy@google.com>
In-Reply-To: <220413.865yncg7et.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 19 quoted lines

> 
> On Wed, Apr 13 2022, brian m. carlson wrote:
> 
> > [[PGP Signed Part:Undecided]]
> > On 2022-04-12 at 20:14:34, Jonathan Tan wrote:
> >> This seems like you're using the commit message as the reflog message -
> >> is this necessary? For what it's worth, all tests still pass if I
> >> replace "msg" with "NULL".
> >
> > I think that's what the existing stash code does, and so I did the same
> > here.  It's not strictly necessary, but it's a nice to have.
> 
> In any case: Jonathan changed the code to omit the commit message & the
> tests still passed? Is that to do with:
> 
>     We specifically rely on the fact that we'll produce identical stash
>     commits on both sides in our tests.
> 
> I.e. that they're checking round-tripping, but not known correctness?

To clarify: I omitted something in the reflog message, not in any of the commit messages. The round-tripping only checks commit messages (which I agree is the important thing). I still do think that the correctness of what's being exported is important, but brian has already said that he can send a followup as part of a new series [1].

[1] https://lore.kernel.org/git/YlYjgLcnNH8V1yj0@camp.crustytoothpaste.net/