Re: [PATCH v3 0/3] Allow --ancestry-path to take an argument

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2022, 21:08 UTC
Message-ID: <xmqqtu68j60w.fsf@gitster.g>
In-Reply-To: <7b7918f8-d997-89e8-2ba0-7bb31beb9335@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 15 quoted lines

> On 8/19/2022 12:28 AM, Elijah Newren via GitGitGadget wrote:
>> Changes since v2:
>> 
>>  * Incorporated Stolee's suggested patch as a preliminary cleanup of t6019.
>>    Slightly modified his patch by:
>>    * fixing the "repetitive" typo pointed out by Eric
>>    * removed the unnecessary "return 1" pointed out by Ævar
>>    * switched "rev-list" to "log" since we are using --format anyway, in
>>      order to remove the need to call "sed" afterward
>
> Thanks! I appreciate you fixing all of my mistakes and
> incorporating all of the existing feedback. It also looks
> nicer as your patch 2 than as a third on top.
>
> This version looks good to me.

Yup, it looks good to me, too.  Thanks, both.

Let's mark it for 'next' and merge it down soonish.