Re: [PATCH v3 3/3] revision: allow --ancestry-path to take an argument

From: Elijah Newren <newren@gmail.com>
Date: Aug 20, 2022, 00:10 UTC
Message-ID: <CABPp-BEvDjBqPxrAEzUXaLFWcwK+UmVH7bDXZm30RRrjv++Gxw@mail.gmail.com>
In-Reply-To: <xmqq7d34m84p.fsf@gitster.g>

On Fri, Aug 19, 2022 at 10:54 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> >                       ancestry_path:1,
> > +
> > +                     /* True if --ancestry-path was specified without an
> > +                      * argument. The bottom revisions are implicitly
> > +                      * the arguments in this case.
> > +                      */
> > +                     ancestry_path_implicit_bottoms:1,
>
> The above comment explains why this is called "implicit" very well.
> The earlier round used "need", but the word missed the essense (i.e.
> ancestry_path argument is implicit and not given, so we need to
> compute bottoms and use them instead).  The new name is certainly
> better.

Yep, I agree, but all credit for this improvement goes to Jonathan; this was one of many good suggestions in his careful review.