Re: [PATCH v3 3/3] revision: allow --ancestry-path to take an argument

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2022, 17:54 UTC
Message-ID: <xmqq7d34m84p.fsf@gitster.g>
In-Reply-To: <b810b3c8a2a7a9d121fc7c0438b4e4f3679557da.1660883290.git.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

>  			ancestry_path:1,
> +
> +			/* True if --ancestry-path was specified without an
> +			 * argument. The bottom revisions are implicitly
> +			 * the arguments in this case.
> +			 */
> +			ancestry_path_implicit_bottoms:1,

The above comment explains why this is called "implicit" very well. The earlier round used "need", but the word missed the essense (i.e. ancestry_path argument is implicit and not given, so we need to compute bottoms and use them instead). The new name is certainly better.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.