Re: [PATCH v2 2/2] revision: allow --ancestry-path to take an argument
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 18, 2022, 16:56 UTC
- Message-ID
- <CAPig+cSerOZbVUH=Twh_yKiZH7wJdUQ+Wk_sp3pL7bR4rR8f2g@mail.gmail.com>
- In-Reply-To
- <220818.86ilmp8rzn.gmgdl@evledraar.gmail.com>
On Thu, Aug 18, 2022 at 12:01 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 7 quoted lines
> On Thu, Aug 18 2022, Derrick Stolee wrote:
> > +test_ancestry () {
> > + args=$1
> > + expected=$2
>
> Maybe add &&-chaining here (we do it in some cases, but I'm not sure
> when such assignments would ever fail).Assignment shouldn't fail, but keeping the &&-chain intact here protects us against the unlikely event of someone inserting &&-chained code above these assignments and not realizing that the &&-chain is not intact at the assignment lines.