Re: [PATCH 1/2] ci(main): upgrade actions/checkout to v3

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2022, 20:55 UTC
Message-ID: <xmqqtu4b1jqg.fsf@gitster.g>
In-Reply-To: <2dbb779f7fde175a8acd8e9de7c81db32fdf3e81.1665388136.git.gitgitgadget@gmail.com>

"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to be up to date with actions/checkout opens the door to use the latest
> features if necessary and get the latest security patches.
>
> Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>
> ---
>  .github/workflows/main.yml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Hmph. When 0dc787a9 (ci: accelerate the checkout, 2021-07-04) updated us from actions/checkout@v1 to actions/checkout@v2 it listed a lot more concrete "what we gain by doing this change", than the hand-wavy "opens the door" argument.

And it left container jobs at @v1 with an explanation that @v2 seemed to be incompatible. If the issue has that been resolved in @v3, it would be necessary to say that the issue has been resolved and it is safe to use @v3 there in the proposed log message.

Show 14 quoted lines

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 831f4df56c5..8dc9d938159 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> ...
> @@ -291,7 +291,7 @@ jobs:
>      runs-on: ubuntu-latest
>      container: ${{matrix.vector.image}}
>      steps:
> -    - uses: actions/checkout@v1
> +    - uses: actions/checkout@v3
>      - run: ci/install-docker-dependencies.sh
>      - run: ci/run-build-and-tests.sh
>      - name: print test failures