Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2022, 21:00 UTC
Message-ID: <xmqqo7uj1jj3.fsf@gitster.g>
In-Reply-To: <4ee163b9a2c4c657e649159ae6c83b13613028f3.1665388136.git.gitgitgadget@gmail.com>

"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to prevent issue tracked in https://github.com/actions/checkout/issues/560
>
> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
> ---
>  .github/workflows/main.yml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

So, this is "[Patch 1/2] broke the musl job by blindly updating them to v3 and here is a fix-up" patch? Can we rearrange so that we have no such "oops here is a fix" that breaks bisection easily?

Show 26 quoted lines

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 8dc9d938159..4eb5042f0d6 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -281,17 +281,20 @@ jobs:
>          vector:
>          - jobname: linux-musl
>            image: alpine
> +          checkout_version: 3
>          - jobname: linux32
>            os: ubuntu32
>            image: daald/ubuntu32:xenial
> +          checkout_version: 2
>          - jobname: pedantic
>            image: fedora
> +          checkout_version: 3
>      env:
>        jobname: ${{matrix.vector.jobname}}
>      runs-on: ubuntu-latest
>      container: ${{matrix.vector.image}}
>      steps:
> -    - uses: actions/checkout@v3
> +    - uses: actions/checkout@${{matrix.vector.checkout_version}}
>      - run: ci/install-docker-dependencies.sh
>      - run: ci/run-build-and-tests.sh
>      - name: print test failures