Re: [PATCH v2] ci(main): upgrade actions/checkout to v3

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2022, 23:28 UTC
Message-ID: <xmqqmt81ph0u.fsf@gitster.g>
In-Reply-To: <pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com>

"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 15 quoted lines

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> To be up to date with actions/checkout opens the door to use the latest
> features if necessary and get the latest security patches.
>
> This also avoids a couple of deprecation warnings in the CI runs.
>
> Note: The `actions/checkout` Action has been known to be broken in i686
> containers as of v2, therefore we keep forcing it to v1 there. See
> actions/runner#2115 for more details.
>
> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---

I do not know about Johannes, but the latter two S-o-b by others are very questionable, as this is the first time I see this iteration of the patch. The chain of S-o-b is used to record that the author handed the patch to somebody else who forwarded it to another (i.e. the order of custody), and the above makes it look as if I picked this iteration of your patch up, passed it to Johannes, and he gave it to the mailing list readers with this message.

If you wanted to say "Input from Johannes helped me greatly while I polished the earlier work to produce this version", it is more appropriate to end the proposed log message with:

	Helped-by: Johannes Schindelin <...>
	Signed-off-by: Oscar Dominguez <...>

in chronological order.

In any case, I've been disturbed by the "Node 12 is going away, use the one that works with Node 16" warning at GitHub CI for the past few weeks and it is very welcome to see this topic moving forward.

Thanks for working on it.