Re: [PATCH v7 00/19] leak fixes: various simple leak fixes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 7, 2023, 00:13 UTC
- Message-ID
- <xmqqttzy1geq.fsf@gitster.g>
- In-Reply-To
- <cover-v7-00.19-00000000000-20230206T230141Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 6 quoted lines
> See > https://lore.kernel.org/git/cover-v6-00.19-00000000000-20230202T094704Z-avarab@gmail.com/#t > for the v6. Changes since then: > > * Corrected the 17/19 commit message to note that it free()'s an > entire allocated struct, not just its "flex" member.
Yup. There isn't much point in saying that the struct gained a flex-array member during the course of its life. The fact that we forgot to free the struct but now we do is what matters.
> * Per my replies on 18/19 and 19/19 in v6 I think those commit > messages are correct as-is, so sending this in in case Junio's OK > with picking up this version.
These looked OK to me.
Thanks.