Re: [PATCH v5 18/19] receive-pack: free() the "ref_name" in "struct command"
- From
Elijah Newren <newren@gmail.com>
- Date
- Jan 26, 2023, 02:37 UTC
- Message-ID
- <CABPp-BFpmEDHXaeXcmXpAuC0xue2b8wrYA560aC7d7tnO25LTw@mail.gmail.com>
- In-Reply-To
- <patch-v5-18.19-3c3d48df04b-20230118T120334Z-avarab@gmail.com>
On Wed, Jan 18, 2023 at 4:54 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 6 quoted lines
> > Fix a memory leak that's been with us since this code was introduced > in 575f497456e (Add first cut at "git-receive-pack", 2005-06-29), see > eb1af2df0b1 (git-receive-pack: start parsing ref update commands, > 2005-06-29) for the later change that refactored the code to add the > "ref_name" member.
This should be two sentences, not one. s/), see/). See/ should do it.
Show 14 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > builtin/receive-pack.c | 10 ++++++++++ > t/t5405-send-pack-rewind.sh | 1 + > t/t5406-remote-rejects.sh | 1 + > t/t5507-remote-environment.sh | 2 ++ > t/t5522-pull-symlink.sh | 1 + > t/t5527-fetch-odd-refs.sh | 1 + > t/t5560-http-backend-noserver.sh | 1 + > t/t5561-http-backend.sh | 1 + > t/t5562-http-backend-content-length.sh | 2 ++ > t/t5705-session-id-in-capabilities.sh | 1 + > 10 files changed, 21 insertions(+) >
[...]
Code changes look good.