Re: [PATCH v3 13/19] builtin/merge.c: always free "struct strbuf msg"

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 13, 2023, 19:57 UTC
Message-ID: <xmqqcz7i2on4.fsf@gitster.g>
In-Reply-To: <71e7d424-b785-9f9e-8b09-955b56fa19b0@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 7 quoted lines

> Am 10.01.23 um 06:43 schrieb Ævar Arnfjörð Bjarmason:
>> Follow-up 465028e0e25 (merge: add missing strbuf_release(),
>> 2021-10-07) and address the "msg" memory leak in this block. We could
>> free "&msg" before the "goto done" here, but even better is to avoid
>> allocating it in the first place.
>
> So contrary to the subject we don't need to free it anymore.

;-)  I appreciate such careful reading.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.