Re: [PATCH v4 08/19] worktree: fix a trivial leak in prune_worktrees()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 18, 2023, 16:16 UTC
- Message-ID
- <xmqqedrr6cnp.fsf@gitster.g>
- In-Reply-To
- <230118.86o7qwxg4e.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 14 quoted lines
>> diff --git c/builtin/branch.c w/builtin/branch.c
>> index f63fd45edb..4fe7757670 100644
>> --- c/builtin/branch.c
>> +++ w/builtin/branch.c
>> @@ -742,6 +742,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
>> if (filter.abbrev == -1)
>> filter.abbrev = DEFAULT_ABBREV;
>> filter.ignore_case = icase;
>> + UNLEAK(filter);
>>
>> finalize_colopts(&colopts, -1);
>> if (filter.verbose) {
>
> I'll send a v5 re-roll without this change, sorry.I'd rather see your reroll with the above addition of UNLEAK() than without it, to fix the breakage.